Repository navigation
feat(structure): rebuild the Structure tab as one Definition page with an inspector - #3872
Merged
Merged
Conversation
…efore a key column goes
… follow the save hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StructureDefinitionEditorwith oneStructureSectionAdapterper section replaces the repointed grid andCreateTableGridAdapter; rows are identified by definition id, so selection survives a reload, a sort or a removal.structureActionsclosures andInspectorRowSourceare gone.fitsRowsmode (as tall as its rows, vertical scroll handed to the page).skipSchemaPreviewdefault turned Preview SQL into Save; Preview skipped Save's validation; Create Table's foreign key menus read the sidebar's database; errors showed unlocalized change names; multi-row paste and duplicate took one undo per row; leaving Structure for Data dimmed Save while edits stayed staged; the inspector named every schema row "Column of"; Cmd+Shift+D did nothing in Structure.FieldEditorKind.typePicker,.valuePicker,.schemaTextand their views).TableCommentStatementTests.driverWithoutStatementThrowsnow expects the localized change name.Test plan
StructureDefinitionEditorTests,StructureChangeManagerStagingTests(primary key staging, rename, delete and Undo Delete, redo),StructureSectionAdapterTests,StructureAvailabilityTests,StructureInspectorFormTests,StructureInspectorPresentationTests,CreateTableDraftCommandTests,StructureCommandRoutingTests,DataGridFittingHeightTests; the old structure suites migrated to the new API.StructureSaveConfirmationUITests,TableChangeReloadUITestsandSidebarAddMenuUITestsupdated to the new identifiers; they run on CI's UI plan.