Repository navigation
Complete the Charts and Catalog breadcrumb hierarchy - #1467
Conversation
…n-breadcrumbs # Conflicts: # src/components/charts/ChartsCatalogPages.tsx # src/utils/chart-breadcrumbs.ts # tests/chart-breadcrumbs.test.ts
|
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Breadcrumb trails and structured data src/utils/chart-breadcrumbs.ts, tests/chart-breadcrumbs.test.ts |
Shared helpers define catalog and collection breadcrumb trails and generate JSON-LD with numbered entries and canonical URLs. Tests cover the breadcrumb labels, links, and structured data. |
Catalog page and route integration src/components/charts/ChartsCatalogPages.tsx, src/routes/_library/charts.catalog.index.tsx, src/routes/_library/charts.catalog.collections.$collectionId.tsx |
Catalog and collection pages display their breadcrumb trails. Catalog and collection route heads emit serialized breadcrumb JSON-LD when loader data exists. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Possibly related PRs
- TanStack/tanstack.com#1465: Adds the chart breadcrumb helpers that this change extends with catalog and collection trails.
- TanStack/tanstack.com#1462: Updates breadcrumb link matching behavior that applies to the ancestor links added by this change.
Merge Risk: 
be612
-
The catalog hierarchy and structured data can be merged with no new blocking issue identified.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: completing the Charts and Catalog breadcrumb hierarchy. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 5 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | c70329b | Commit Preview URL Branch Preview URL |
Nov 01 2026, 02:58 AM |
The catalog root now has a Charts / Catalog trail. Collection and example trails reuse those ancestors, completing the chart hierarchy requested in #1151 while preserving search parameters on return links. The same items produce canonical BreadcrumbList data. Root schema is omitted when its loader fails.
The collection prerequisite #1466 is merged. Library landing pages are covered separately in #1468, and documentation coverage is still pending.
Validation: full pnpm test through normal hooks; hierarchy and canonical URL regression tests; installed Router/shared-component SSR, including the actual root head callback on success and not-found. The deployed preview was checked at desktop and 375px for the root and a four-item example trail, with no horizontal overflow, one current breadcrumb, and keyboard navigation preserving the theme query. Preview SSR emits canonical production URLs.