Skip to content

Add breadcrumbs to public library landing pages - #1468

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/library-landing-breadcrumbs
Nov 1, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/library-landing-breadcrumbs

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Library landing pages now show a Libraries / library-name trail and emit matching canonical BreadcrumbList data. Hidden libraries, missing landing destinations, and unsuccessful route matches omit the trail. Other library routes keep their existing navigation.

Part of #1151, which remains open for the remaining documentation coverage.

Validation: full repository tests through normal commit hooks; regression tests for canonical labels and URLs, hidden libraries, and missing destinations; an isolated installed-Router SSR fixture using the actual copied head callback verifies public success, not-found, and hidden-library cases. The exact-head application preview was checked at desktop and 375px for Query, with keyboard navigation to Libraries, and on the Charts landing page. Six SSR responses verify public landing schema and its exclusion from hidden libraries, docs, the catalog, and a not-found page. No horizontal overflow or duplicate current item was observed.

@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6723cf0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8593f746-4fe1-4c01-ab44-9ee43ded368e
Commits

Reviewing files that changed from the base of the PR and between e10317d and 6723cf0.

Files selected for processing: 25
  • src/components/LibraryLayout.tsx
  • src/routes/-library-landing-route.tsx
  • src/routes/_library/ai.$version.index.tsx
  • src/routes/_library/charts.$version.index.tsx
  • src/routes/_library/cli.$version.index.tsx
  • src/routes/_library/config.$version.index.tsx
  • src/routes/_library/db.$version.index.tsx
  • src/routes/_library/devtools.$version.index.tsx
  • src/routes/_library/form.$version.index.tsx
  • src/routes/_library/highlight.$version.index.tsx
  • src/routes/_library/hotkeys.$version.index.tsx
  • src/routes/_library/intent.$version.index.tsx
  • src/routes/_library/markdown.$version.index.tsx
  • src/routes/_library/pacer.$version.index.tsx
  • src/routes/_library/query.$version.index.tsx
  • src/routes/_library/ranger.$version.index.tsx
  • src/routes/_library/redact.$version.index.tsx
  • src/routes/_library/router.$version.index.tsx
  • src/routes/_library/start.$version.index.tsx
  • src/routes/_library/store.$version.index.tsx
  • src/routes/_library/table.$version.index.tsx
  • src/routes/_library/virtual.$version.index.tsx
  • src/routes/_library/workflow.$version.index.tsx
  • src/utils/library-breadcrumbs.ts
  • tests/library-breadcrumbs.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 6723cf0 Commit Preview URL

Branch Preview URL
Nov 01 2026, 02:54 AM

@tannerlinsley
tannerlinsley merged commit d72c534 into main Nov 1, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the taren/library-landing-breadcrumbs branch November 1, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant