Repository navigation
fix: run the Pose cases of the RPC serialization tests - #4220
NoelStephensUnity wants to merge 6 commits into
Conversation
The Pose branches called the coroutine helpers without yield return, so the Pose cases passed without running and their native collections were never disposed.
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Harness Review
The four added yields correctly execute the existing Pose RPC test coroutines. I examined all changed branches, matching RPC methods, assertions, native collection disposal, and compilation guards; no actionable issues were found.
Reviewed commit a1a4505
🤖 Helpful? 👍/👎
Pull request was converted to draft
There was a problem hiding this comment.
💡 Harness Review
The four additions correctly run the previously skipped Pose coroutine tests. I examined the matching RPC methods, helper assertions, native collection disposal, and neighboring branches, and found no actionable issues.
Reviewed commit 12d8fe3
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4220 +/- ##
=================================================
- Coverage 76.91% 76.85% -0.06%
=================================================
Files 159 159
Lines 27603 27624 +21
=================================================
Hits 21230 21230
- Misses 6373 6394 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose of this PR
The
Posecases ofRpcTypeSerializationTestspassed without running. Their branches called the coroutine helpers withoutyield return, so the RPCs were never sent or checked, and theNativeArray/NativeListcases never disposed their collections. Those collections are the 6 allocations left after #4219 in the unified suite's leak report.PR Scope:
yield returnto all fourPosebranches: single value, managed array,NativeArrayandNativeList.Jira ticket
None.
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsRpcTypeSerializationTests:Server132/132 andUnifiedServer132/132 passed, with allPosecases now running.Does the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Up-port
Not needed: targets develop-3.x.x. The same
Posebranches exist on develop-2.0.0 if a port is wanted.Backports
None.