Repository navigation
fix: send isRunning=false in stop() to stop frontend progress bar - #38
Open
mokhtardziri wants to merge 3 commits into
Open
mokhtardziri wants to merge 3 commits into
mokhtardziri wants to merge 3 commits into
Conversation
mokhtardziri
force-pushed
the
fix-frontend-progress-bar
branch
from
August 28, 2026 08:09
05cca7b to
4cf1dba
Compare
This was referenced Oct 24, 2026
pashidlos
pushed a commit
that referenced
this pull request
Oct 24, 2026
stop() sent PATCH /builds/:id with an empty JSON body. Backend api-v5.1.0
dropped the fallback that treated an empty body as a stop request, so the
build stays running. Send {"isRunning": false} explicitly, which every
backend version accepts.
Based on #38 by @mokhtardziri.
Fixes Visual-Regression-Tracker/backend#343
Co-Authored-By: mokhtar.dziri <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
pashidlos
added a commit
that referenced
this pull request
Oct 24, 2026
* chore(deps): drop EOL Python versions and fix CI CI no longer starts (zero jobs; the matrix asks for Python 3.6 and uses outdated actions), and the async Playwright tests fail with current pytest-asyncio / Python 3.12+. - test on Python 3.9 - 3.14, python_requires >= 3.9 - actions/checkout@v4, actions/setup-python@v5, drop the archived microsoft/playwright-github-action (install chromium deps directly) - run the Codacy coverage upload only on push (no secrets on fork PRs) - requirements: drop pre-3.9 markers and nest_asyncio, require pytest-asyncio >= 0.24 (loop_scope) - tests: move async Playwright tests to their own module with session-scoped pytest-asyncio fixtures, and scope the sync Playwright fixtures per module so its event loop is stopped before them Co-Authored-By: Claude Opus 5.5 <[email protected]> * chore(ci): use Node 24 based checkout and setup-python actions Co-Authored-By: Claude Opus 5.5 <[email protected]> * fix: send isRunning=false in stop() stop() sent PATCH /builds/:id with an empty JSON body. Backend api-v5.1.0 dropped the fallback that treated an empty body as a stop request, so the build stays running. Send {"isRunning": false} explicitly, which every backend version accepts. Based on #38 by @mokhtardziri. Fixes Visual-Regression-Tracker/backend#343 Co-Authored-By: mokhtar.dziri <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]> --------- Co-authored-by: Pavlo Strunkin <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> Co-authored-by: mokhtar.dziri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.