Repository navigation
fix: send isRunning=false in stop() - #40
Merged
Merged
Conversation
CI no longer starts (zero jobs; the matrix asks for Python 3.6 and uses outdated actions), and the async Playwright tests fail with current pytest-asyncio / Python 3.12+. - test on Python 3.9 - 3.14, python_requires >= 3.9 - actions/checkout@v4, actions/setup-python@v5, drop the archived microsoft/playwright-github-action (install chromium deps directly) - run the Codacy coverage upload only on push (no secrets on fork PRs) - requirements: drop pre-3.9 markers and nest_asyncio, require pytest-asyncio >= 0.24 (loop_scope) - tests: move async Playwright tests to their own module with session-scoped pytest-asyncio fixtures, and scope the sync Playwright fixtures per module so its event loop is stopped before them Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
stop() sent PATCH /builds/:id with an empty JSON body. Backend api-v5.1.0
dropped the fallback that treated an empty body as a stop request, so the
build stays running. Send {"isRunning": false} explicitly, which every
backend version accepts.
Based on #38 by @mokhtardziri.
Fixes Visual-Regression-Tracker/backend#343
Co-Authored-By: mokhtar.dziri <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
pashidlos
force-pushed
the
fix/343-stop-is-running
branch
from
October 24, 2026 07:44
40b7842 to
77b1621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VisualRegressionTracker.stop()no longer stops the build on backend api-v5.1.0 and later. The build stays Running in the UI (Visual-Regression-Tracker/backend#343).Root cause
stop()sendsPATCH /builds/:idwith{}as the body. The backend used to treat an empty body asisRunning = false, but the NestJS 11 upgrade (Visual-Regression-Tracker/backend#336) removed that fallback, so{}is now a no-op. The frontend sends{"isRunning": false}explicitly.Fix
stop()now sends{"isRunning": false}. Every backend version supports this. This is the change from #38 by @mokhtardziri (credited as co-author). This PR drops the unrelated whitespace change tosetup.pyfrom #38 and updates the unit test that asserted the old empty body.The backend is also being made backward compatible again (Visual-Regression-Tracker/backend#410), so older SDK releases keep working too.
Stacked on #39 (CI/deps refresh). Please merge #39 first. Until then this PR's diff also shows #39's commit.
Tests
test__stop__should_stop_buildnow assertsdata={'isRunning': False}. It fails on the old code and passes with the fix.pytest tests: 67 passed (Python 3.14).pylint -E: 10.00/10.Fixes Visual-Regression-Tracker/backend#343
Supersedes #38
🤖 Generated with Claude Code