Skip to content

fix: send isRunning=false in stop() #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pashidlos merged 4 commits into from
Oct 24, 2026
Merged

fix: send isRunning=false in stop() #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a076e4
chore(deps): drop EOL Python versions and fix CI
Oct 24, 2026
7672e22
chore(ci): use Node 24 based checkout and setup-python actions
Oct 24, 2026
77b1621
fix: send isRunning=false in stop()
Oct 24, 2026
d5a62a0
Merge branch 'master' into fix/343-stop-is-running
pashidlos Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_visualRegressionTracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def test__stop__should_stop_build(vrt, mock_request, mocker):
mock_request.assert_called_once_with(
f'{CONFIG.apiUrl}/builds/{buildId}',
'patch',
data={},
data={'isRunning': False},
headers={
'apiKey': CONFIG.apiKey,
'project': CONFIG.project
Expand Down
2 changes: 1 addition & 1 deletion visual_regression_tracker/visualRegressionTracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def stop(self):
_http_request(
f'{self.config.apiUrl}/builds/{self.buildId}',
'patch',
data={},
data={'isRunning': False},
headers=self.headers
)
self.buildId = None
Expand Down
Loading