Repository navigation
fix(@schematics/angular): keep the default ng-packagr output path in use-library-builder - #34603
Merged
alan-agius4 merged 1 commit intoOct 30, 2026
Conversation
…use-library-builder The migration only sets `outputPath` when the ng-packagr configuration has a `dest`. Without it, ng-packagr writes to `dist` within the package directory, while the library builder defaults to `dist/<project>`, so the migrated library is silently built to a different location. Set `outputPath` to the ng-packagr default when `dest` is not set. A new spec fails without this change.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the library builder migration schematic to default the output path to 'dist' within the project directory when the dest property is not defined in the ng-package.json configuration. It also adds a corresponding unit test to verify this behavior. There are no review comments, and I have no additional feedback to provide.
alan-agius4
added
target: patch
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration only sets
outputPathwhen the ng-packagr configuration has adest. Without it, ng-packagr writes todistwithin the package directory, while the library builder defaults todist/<project>, so the migrated library is silently built to a different location.Set
outputPathto the ng-packagr default whendestis not set. A new spec fails without this change.