Skip to content

fix(@schematics/angular): keep the default ng-packagr output path in use-library-builder #34603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Oct 30, 2026
Merged

fix(@schematics/angular): keep the default ng-packagr output path in use-library-builder #34603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/schematics/angular/migrations/use-library-builder/migration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,9 @@ function migrateTargetOptions(
delete buildTarget.configurations?.['development']?.['tsConfig'];
}

if (ngPackageConfig?.dest && typeof buildTarget.options['outputPath'] !== 'string') {
buildTarget.options['outputPath'] = join(projectDir, ngPackageConfig.dest);
if (typeof buildTarget.options['outputPath'] !== 'string') {
// `ng-packagr` writes to `dist` within the package directory when `dest` is not set.
buildTarget.options['outputPath'] = join(projectDir, ngPackageConfig?.dest ?? 'dist');
}

if (ngPackageConfig?.assets?.length) {
Expand Down
12 changes: 12 additions & 0 deletions packages/schematics/angular/migrations/use-library-builder/migration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,18 @@ describe('Migration to use the library builder', () => {
expect(newTree.exists('/projects/my-lib/ng-package.json')).toBe(false);
});

it('should keep the default ng-packagr output path when dest is not set', async () => {
tree.overwrite(
'/projects/my-lib/ng-package.json',
JSON.stringify({ lib: { entryFile: 'src/public-api.ts' } }),
);

const newTree = await schematicRunner.runSchematic(schematicName, {}, tree);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const { projects } = newTree.readJson('/angular.json') as any;
expect(projects['my-lib'].architect['build'].options.outputPath).toBe('projects/my-lib/dist');
});

it('should migrate @angular/build:ng-packagr and promote tsConfig from development configuration', async () => {
const angularJson = JSON.parse(tree.readContent('/angular.json'));
angularJson.projects['my-lib'].architect.build = {
Expand Down
Loading