Repository navigation
A11Y-13878: Scan Chrome on Android and Safari on iPhone for accessibility (v8) - #312
Draft
palspal-bstack wants to merge 2 commits into
Draft
palspal-bstack wants to merge 2 commits into
palspal-bstack wants to merge 2 commits into
Conversation
Port of the v9 mobile web accessibility change. validateCapsWithA11y accepts Chrome on Android and Safari on iPhone when the group is entitled (iOS on unless the backend opts the group out), the scan, results, summary and save scripts get the mobile session args in both the classic and CLI flows, and mobile sessions get a script timeout from the backend's scannerProcessingTimeout (30s default) so async scans don't hit XCUITest's ~0 ms default. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
v8 port of #311. Runs accessibility scans in-page on mobile browsers: Chrome on Android, and Safari on iPhone (iPad excluded). Today the service turns accessibility off for any session with a
deviceName.isMobileScanningEnabledForGroup,isIosSafariScanningEnabledForGroupandscannerProcessingTimeoutinto env in the launcher, so workers inherit them. iOS is on unless the backend sendsfalse(prod doesn't send the iOS flag yet).validateCapsWithA11y: allows Chrome on Android, and Safari on iPhone, when the group has mobile scanning. Works out the platform from the device name when session caps report the Appium host OS.is_mobile_sessionandthTestRunUuidon mobile, in both the classic and CLI flows. A rejected mobile save is logged as an error.scannerProcessingTimeout(30s when it isn't sent, as in the Node SDK). Appium XCUITest starts iOS sessions with a ~0 ms timeout, so every scan timed out before this.Same behaviour as #311, adapted to v8's direct
executeAsynccalls (v8 has noexecuteAccessibilityScript).Tested on prod with WDIO 8.46.0 and a packed build of this branch (8.54.0):
3944e0860b90f32e8c32cf103add7f1dIssue counts match the WDIO 9 runs on #311.
Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
isIosSafariScanningEnabledForGroup: false.is_mobile_sessionandthTestRunUuidin the classic and CLI flows.scannerProcessingTimeoutas their async script timeout, to work around Appium XCUITest's ~0 ms default on iOS.Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.
🤖 Generated with Claude Code