Skip to content

Fix SSDP example and minor documentation improvements - #30

Merged
clue merged 1 commit into
clue:1.xfrom
clue-labs:fix-examples
Oct 25, 2026
Merged

clue merged 1 commit into
clue:1.xfrom
clue-labs:fix-examples

Conversation

@clue

@clue clue commented Oct 25, 2026

Copy link
Copy Markdown
Owner

This changeset fixes the SSDP example, which has been failing with Class "Loop" not found ever since #21 (2021) updated the examples to use the default loop. It now uses the fully qualified React\EventLoop\Loop class like all other examples and links to clue/reactphp-ssdp, along with some minor cleanups in the examples and documentation. Examples and documentation only, the library itself is unchanged.

Builds on top of #21

@clue clue added bug Something isn't working easy pick Good for newcomers maintenance labels Oct 25, 2026
@clue clue added this to the v1.3.0 milestone Oct 25, 2026
@clue
clue requested a balanced review from Copilot October 25, 2026 22:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The targeted class-reference fix resolves the example failure, and the remaining edits affect only documentation and whitespace.

No open issues 🎉

What changed in this PR

Fixes the SSDP example’s Class "Loop" not found error following the default-loop migration in #21. Library code is unchanged.

Changes:

  • Uses the fully qualified React\EventLoop\Loop class in the SSDP example.
  • Adds a link to clue/reactphp-ssdp.
  • Corrects UPnP capitalization in comments and removes extra whitespace.
File Description
README.md Removes trailing whitespace from a code example.
examples/​ssdp.php Fixes the loop class reference and adds an SSDP project link.
examples/​echo-received.php Corrects UPnP capitalization in a comment.
examples/​dump-received.php Corrects comment capitalization and removes a trailing blank line.

Review effort: Balanced

@clue
clue merged commit 28ca185 into clue:1.x Oct 25, 2026
16 checks passed
@clue
clue deleted the fix-examples branch October 25, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working easy pick Good for newcomers maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants