Repository navigation
Fix SSDP example and minor documentation improvements - #30
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The targeted class-reference fix resolves the example failure, and the remaining edits affect only documentation and whitespace.
No open issues 🎉
What changed in this PR
Fixes the SSDP example’s Class "Loop" not found error following the default-loop migration in #21. Library code is unchanged.
Changes:
- Uses the fully qualified
React\EventLoop\Loopclass in the SSDP example. - Adds a link to
clue/reactphp-ssdp. - Corrects UPnP capitalization in comments and removes extra whitespace.
| File | Description |
|---|---|
| README.md | Removes trailing whitespace from a code example. |
| examples/ssdp.php | Fixes the loop class reference and adds an SSDP project link. |
| examples/echo-received.php | Corrects UPnP capitalization in a comment. |
| examples/dump-received.php | Corrects comment capitalization and removes a trailing blank line. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes the SSDP example, which has been failing with
Class "Loop" not foundever since #21 (2021) updated the examples to use the default loop. It now uses the fully qualifiedReact\EventLoop\Loopclass like all other examples and links to clue/reactphp-ssdp, along with some minor cleanups in the examples and documentation. Examples and documentation only, the library itself is unchanged.Builds on top of #21