Repository navigation
sqlite storage: wrap store batch in a single transaction - #25
Merged
Merged
Conversation
sqlite3_exec commits each statement in its own implicit transaction, so a bulk store of N entries costs N fsync-bound commits. Wrapping the upsert batch in BEGIN IMMEDIATE/COMMIT collapses it to one commit.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage_storeconcatenates all upserts into onesqlite3_execbatch, but without an explicit transaction each statement commits in its own implicit transaction — a bulk store of N entries costs N fsync-bound commits.Measured on a ~130 MB index build (Out's 4k-movies benchmark graph): the store phase spent ~50s almost entirely inside
vdbeCommit/sqlite3PagerCommitPhaseOne/unixSync. Wrapping the batch inBEGIN IMMEDIATE/COMMITcollapses it into one transaction: saving phase 50s → 5.3s, total first import 68.8s → 22.4s.Link to Devin session: https://app.devin.ai/sessions/87d07eb19d674693adeffdb53332c183
Open in Devin Desktop: https://app.devin.ai/desktop/session/87d07eb19d674693adeffdb53332c183?variant=devin
Requested by: @tiensonqin