Skip to content

sqlite storage: wrap store batch in a single transaction #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiensonqin merged 1 commit into from
Oct 1, 2026
Merged

sqlite storage: wrap store batch in a single transaction #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/logseq_sqlite_storage.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,10 @@ let storage db_path =
create_kvs_table db_path;
let store entries =
let sql = String.concat "" (List.map upsert_sql entries) in
if sql <> "" then exec_sql db_path sql
(* Without an explicit transaction sqlite3_exec commits every
statement separately — thousands of fsyncs on a bulk store.
One transaction costs one commit's worth of syncs. *)
if sql <> "" then exec_sql db_path ("begin immediate;" ^ sql ^ "commit;")
in
let restore address =
let addr = sqlite_addr_of_storage_address address in
Expand Down
Loading