Skip to content

build,test: setup perfetto tests on windows build - #66731

Open
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:perfetto-win
Open

legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:perfetto-win

Conversation

@legendecas

Copy link
Copy Markdown
Member

This converts the trace_processor_shell script to a python script so that it
can be ran on Windows as well. This also adds a flag with-perfetto in
vcbuild.bat to build Node.js with perfetto support.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.59%. Comparing base (03cca65) to head (b0bb7a3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66731   +/-   ##
=======================================
  Coverage   90.58%   90.59%           
=======================================
  Files         797      797           
  Lines      278297   278297           
  Branches    53515    53516    +1     
=======================================
+ Hits       252096   252119   +23     
+ Misses      16561    16557    -4     
+ Partials     9640     9621   -19     

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas changed the title test: setup perfetto tests on windows build build,test: setup perfetto tests on windows build Oct 14, 2026
Comment thread tools/perfetto/get_trace_processor.py Outdated
Comment thread tools/perfetto/get_trace_processor.py
@legendecas

Copy link
Copy Markdown
Member Author

I will rebase this when #66876 lands.

@legendecas
legendecas force-pushed the perfetto-win branch 2 times, most recently from 44af167 to ad39bf5 Compare October 22, 2026 14:01
@legendecas

Copy link
Copy Markdown
Member Author

Rebased on top of landed commits in #66876

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants