build,win: fix Perfetto by aduh95 · Pull Request #66876 · nodejs/node

�[36m⠋�[39m Validating Jenkins credentials
�[36m⠋�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠙�[39m Looking for CI runs for pull request 66876
�[36m⠙�[39m Looking for CI runs for pull request 66876
�[36m⠙�[39m Getting PR from nodejs/node/pull/66876
�[36m⠙�[39m Getting reviews from nodejs/node/pull/66876
�[36m⠙�[39m Getting comments from nodejs/node/pull/66876
✔  Found PR CI job 78534
�[36m⠹�[39m Querying data for job/node-test-pull-request/78534/
�[36m⠹�[39m Querying data for job/node-test-pull-request/78534/
�[36m⠹�[39m Querying API for job/node-test-pull-request/78534/

[DEBUG] [SyntaxError: Unexpected token '<', ..."    
  
  <!DOCTYPE "... is not valid JSON]
✖  Failed to load PR CI job 78534: Unexpected token '<', ..."    
  
  <!DOCTYPE "... is not valid JSON

View workflow run

nodejs-github-bot · 2026-10-22T14:22:49Z

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
   ✖  GitHub CI is still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output

�[36m⠋�[39m Loading data for nodejs/node/pull/66876
�[36m⠋�[39m Loading data for nodejs/node/pull/66876
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66876
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66876
�[36m⠋�[39m Getting comments from nodejs/node/pull/66876
�[36m⠋�[39m Getting commits from nodejs/node/pull/66876
✔  Done loading data for nodejs/node/pull/66876
----------------------------------- PR info ------------------------------------
Title      build,win: fix Perfetto (#66876)
   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
Branch     aduh95:fix-windows-perfetto-build -> nodejs:main
Labels     build, v8 engine, author ready, needs-ci, dependencies, commit-queue, dont-land-on-v22.x, dont-land-on-v24.x, resume-ci-failed
Commits    2
 - deps: V8: cherry-pick 785a2ea88a90
 - build,win: fix Perfetto
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/66876
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66876
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 20 Oct 2026 14:01:43 GMT
   ✔  Approvals: 4
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/66876#pullrequestreview-5586155404
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/66876#pullrequestreview-5590862014
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/66876#pullrequestreview-5592206175
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/66876#pullrequestreview-5606105383
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-10-20T22:25:47Z: https://ci.nodejs.org/job/node-test-pull-request/78534/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78534/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78534/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78534/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
�[36m⠹�[39m Querying API for job/node-test-pull-request/78534/
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

legendecas

Windows build on #65794 is passed. Tests rely on #66731.

nodejs-github-bot · 2026-10-22T22:36:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/78580/

nodejs-github-bot · 2026-10-22T22:39:25Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7461/

nodejs-github-bot · 2026-10-22T22:39:50Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7461/

nodejs-github-bot · 2026-10-22T22:40:33Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7461/

Original commit message: [tracing] do not define legacy tracing classes when using Perfetto Otherwise the Windows build of Node.js fails with `undefined symbol` errors due to the missing destructor. Change-Id: Id0841aed2f0a8f0cfe8889c39150552e31ee5f96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8580049 Reviewed-by: Yang Guo <[email protected]> Reviewed-by: Chengzhong Wu <[email protected]> Commit-Queue: Chengzhong Wu <[email protected]> Cr-Commit-Position: refs/heads/main@{#110947} Refs: v8/v8@785a2ea PR-URL: nodejs#66876 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>

Signed-off-by: StefanStojanovic <[email protected]> Co-Authored-By: Chengzhong Wu <[email protected]> PR-URL: nodejs#66876 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>

aduh95 · 2026-10-23T08:10:18Z

Landed in 6353f40...4c294b3

codecov · 2026-10-23T09:31:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.93%. Comparing base (6353f40) to head (4c294b3).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #66876   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files         428      428           
  Lines      195236   195236           
  Branches    30179    30189   +10     
=======================================
  Hits       181438   181438           
- Misses      13470    13471    +1     
+ Partials      328      327    -1

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 20, 2026

nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 20, 2026

legendecas approved these changes Oct 20, 2026

View reviewed changes

aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 20, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 20, 2026

lpinca approved these changes Oct 20, 2026

View reviewed changes

juanarbol approved these changes Oct 20, 2026

View reviewed changes

aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2026

gurgunday approved these changes Oct 21, 2026

View reviewed changes

aduh95 mentioned this pull request Oct 22, 2026

build: enable Perfetto by default #65794

Open

legendecas added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 22, 2026

legendecas mentioned this pull request Oct 22, 2026

build,test: setup perfetto tests on windows build #66731

Open

github-actions Bot added resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. and removed resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Oct 22, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 22, 2026

legendecas approved these changes Oct 22, 2026

View reviewed changes

aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 22, 2026

aduh95 and others added 2 commits October 23, 2026 10:06

aduh95 force-pushed the fix-windows-perfetto-build branch from 827d583 to 4c294b3 Compare October 23, 2026 08:09

aduh95 merged commit 4c294b3 into nodejs:main Oct 23, 2026
16 of 20 checks passed

aduh95 deleted the fix-windows-perfetto-build branch October 23, 2026 08:10

Conversation

aduh95 commented Oct 20, 2026

Uh oh!

nodejs-github-bot commented Oct 20, 2026

Uh oh!

nodejs-github-bot commented Oct 20, 2026

Uh oh!

nodejs-github-bot commented Oct 20, 2026

Uh oh!

nodejs-github-bot commented Oct 20, 2026

Uh oh!

nodejs-github-bot commented Oct 20, 2026

Uh oh!

nodejs-github-bot commented Oct 20, 2026

Uh oh!

nodejs-github-bot commented Oct 20, 2026

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 22, 2026

Failed to resume CI

Uh oh!

nodejs-github-bot commented Oct 22, 2026

Commit Queue failed

Uh oh!

legendecas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 22, 2026

Uh oh!

nodejs-github-bot commented Oct 22, 2026

Uh oh!

nodejs-github-bot commented Oct 22, 2026

Uh oh!

nodejs-github-bot commented Oct 22, 2026

Uh oh!

aduh95 commented Oct 23, 2026

Uh oh!

Uh oh!

codecov Bot commented Oct 23, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

legendecas left a comment •

edited

Loading