Repository navigation
gh-159580: Improve performance of isinstance() for misses and improve documentation - #159581
Open
eendebakpt wants to merge 5 commits into
Open
eendebakpt wants to merge 5 commits into
eendebakpt wants to merge 5 commits into
Conversation
Documentation build overview
73 files changed ·
|
| if (PyStackRef_IsNull(cref)) { | ||
| return 0; | ||
| } | ||
| PyObject *descr = PyStackRef_AsPyObjectBorrow(cref); |
Contributor
There was a problem hiding this comment.
you could cache the object.__class__ descriptor in interp state then this would be simple pointer equality check and even faster.
Contributor
Author
There was a problem hiding this comment.
That would require a _PyInterpreterState_GET() call. I tried this locally, but I see no performance improvement.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve performance of
instancein the case of misses by avoiding attribute lookup on__class__. Documentation ofisinstanceis updated to match the actual behavior.Details and benchmarks in the corresponding issue.