Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Doc/builtins/functions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1174,6 +1174,11 @@ are always available. They are listed here in alphabetical order.
a :exc:`TypeError` exception is raised. :exc:`TypeError` may not be
raised for an invalid type if an earlier check succeeds.

If *object* has a ``__class__`` attribute that differs from
:func:`type(object) <type>` (for example a proxy, or a :mod:`unittest.mock`
object created with a *spec*), ``True`` is also returned when that class
is a subclass of *classinfo*.

.. versionchanged:: 3.10
*classinfo* can be a :ref:`types-union`.

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve performance of :func:`isinstance` when the check fails.
25 changes: 25 additions & 0 deletions Objects/abstract.c
Original file line number Diff line number Diff line change
Expand Up @@ -2600,6 +2600,28 @@ check_class(PyObject *cls, const char *error)
return -1;
}

/* Return 1 if inst.__class__ would resolve to object's own getset descriptor,
i.e. evaluate to Py_TYPE(inst). Types with a custom tp_getattro or an
overridden __class__ return 0 and take the generic lookup. */
static inline int
class_attr_is_type(PyObject *inst)
{
PyTypeObject *tp = Py_TYPE(inst);
if (tp->tp_getattro != PyObject_GenericGetAttr) {
return 0;
}
_PyStackRef cref;
_PyType_LookupStackRefAndVersion(tp, &_Py_ID(__class__), &cref);
if (PyStackRef_IsNull(cref)) {
return 0;
}
PyObject *descr = PyStackRef_AsPyObjectBorrow(cref);

@kumaraditya303 kumaraditya303 Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could cache the object.__class__ descriptor in interp state then this would be simple pointer equality check and even faster.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would require a _PyInterpreterState_GET() call. I tried this locally, but I see no performance improvement.

int res = (Py_IS_TYPE(descr, &PyGetSetDescr_Type)
&& PyDescr_TYPE(descr) == &PyBaseObject_Type);
PyStackRef_CLOSE(cref);
return res;
}

static int
object_isinstance(PyObject *inst, PyObject *cls)
{
Expand All @@ -2608,6 +2630,9 @@ object_isinstance(PyObject *inst, PyObject *cls)
if (PyType_Check(cls)) {
retval = PyObject_TypeCheck(inst, (PyTypeObject *)cls);
if (retval == 0) {
if (class_attr_is_type(inst)) {
return 0;
}
retval = PyObject_GetOptionalAttr(inst, &_Py_ID(__class__), &icls);
if (icls != NULL) {
if (icls != (PyObject *)(Py_TYPE(inst)) && PyType_Check(icls)) {
Expand Down
Loading