Repository navigation
Conversation
SPARC V9 has no frame record. The caller's %fp (biased by 2047) and return address are in slots 14 and 15 of the register window save area at fp, and are only there after the windows have been flushed to the stack.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
Please apply skip news to this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teach the manual frame pointer unwinder in
_testinternalcapithe SPARC V9 frame layout. There's no frame record on SPARC: the caller's %fp (biased by 2047) and its return address are in slots 14 and 15 of the register window save area at fp, and they're only in memory after aflushw.Tested on a SPARC T7-1 and a T4-1 (Linux, GCC 16):
ManualStackUnwindTestsfails without the change and passes with it, and the unwinder walks all the way down to_start. No change on x86_64.The GNU backtrace test still fails on sparc64, that's the missing unwind tables from the issue (GCC PR 128091), not this code.