Skip to content

gh-160253: Fix test_c_stack_unwind manual unwinding on sparc64 #160255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shalseth wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

gh-160253: Fix test_c_stack_unwind manual unwinding on sparc64 #160255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion Modules/_testinternalcapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,20 @@ static const uintptr_t min_frame_pointer_addr = 0x1000;
// address is stored at fp[-1].
# define FRAME_POINTER_NEXT_OFFSET -2
# define FRAME_POINTER_RETURN_OFFSET -1
#elif defined(__sparc__) && defined(__arch64__)
// SPARC V9 has no frame record: fp points to the register window save area,
// where the caller's %fp is saved at fp[14] and its return address (%i7) at
// fp[15]. The saved %fp is biased by 2047.
# define FRAME_POINTER_NEXT_OFFSET 14
# define FRAME_POINTER_RETURN_OFFSET 15
# define FRAME_POINTER_BIAS 2047
#else
# define FRAME_POINTER_NEXT_OFFSET 0
# define FRAME_POINTER_RETURN_OFFSET 1
#endif
#ifndef FRAME_POINTER_BIAS
# define FRAME_POINTER_BIAS 0
#endif


static PyObject *
Expand Down Expand Up @@ -527,7 +537,8 @@ manual_unwind_from_fp(uintptr_t *frame_pointer)
stack_min, stack_max)) {
break;
}
uintptr_t *next_fp = (uintptr_t *)frame_pointer[FRAME_POINTER_NEXT_OFFSET];
uintptr_t *next_fp = (uintptr_t *)(frame_pointer[FRAME_POINTER_NEXT_OFFSET]
+ FRAME_POINTER_BIAS);
uintptr_t return_addr = frame_pointer[FRAME_POINTER_RETURN_OFFSET];

PyObject *addr_obj = PyLong_FromUnsignedLongLong(return_addr);
Expand Down Expand Up @@ -599,6 +610,10 @@ gnu_backtrace_unwind(PyObject *self, PyObject *Py_UNUSED(args))
static PyObject *
manual_frame_pointer_unwind(PyObject *self, PyObject *args)
{
#if defined(__sparc__) && defined(__arch64__)
// The callers' register windows are only in their save areas once spilled.
__asm__ volatile ("flushw" ::: "memory");
#endif
uintptr_t *frame_pointer = (uintptr_t *)__builtin_frame_address(0);
return manual_unwind_from_fp(frame_pointer);
}
Expand Down
Loading