Repository navigation
Remove Heroku leftovers - #751
Merged
Merged
Conversation
miss-islington now runs on cabotage only; the Heroku app is in maintenance mode with all resources scaled to zero. - Drop runtime.txt, which only Heroku read. - Require REDIS_URL and drop the HEROKU_REDIS_MAROON_URL fallback. - Drop the CERT_NONE broker and result backend SSL settings that existed for Heroku's self-signed Redis certificate. On cabotage the rediss:// URL carries ssl_ca_certs and ssl_cert_reqs=required as query parameters. - Build the Docker image on Python 3.15 instead of 3.11, which is the next release to reach end of life. Requested by @hugovk in #729.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #751 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 366 366
Branches 12 12
=========================================
Hits 366 366
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hugovk
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miss-islington now runs on cabotage only. The Heroku app has been put in maintenance mode with all resources scaled to zero, so the Heroku-specific pieces can go.
runtime.txt, which only Heroku read.REDIS_URLand drop theHEROKU_REDIS_MAROON_URLfallback.CERT_NONEbroker and result backend SSL settings that existed for Heroku's self-signed Redis certificate. On cabotage therediss://URL carriesssl_ca_certs=/var/run/secrets/cabotage.io/ca.crt&ssl_cert_reqs=requiredas query parameters, so the Redis certificate is now verified against the cabotage CA (seeinfra/k8s/README.md).Procfilestays: cabotage reads it for thewebandworkerprocesses.Tests pass with 100% coverage, pre-commit passes, and the image builds locally on 3.15 with the C aiohttp parser.