Repository navigation
Fix paginated workflow task completions - #3177
Open
jmaeagle99 wants to merge 2 commits into
Open
jmaeagle99 wants to merge 2 commits into
jmaeagle99 wants to merge 2 commits into
Conversation
Quinn-With-Two-Ns
approved these changes
Oct 30, 2026
Sending a paginated completion threw UnsupportedOperationException before the first page went out. sendPaginatedTaskCompleted extends built RpcRetryOptions with addDoNotRetry, but a builder copied from built options reused their unmodifiable doNotRetry list. Copy the list so a copied builder can be extended without changing the source options. Enable workflow task completion pagination on the dev server used by the tests, and raise its transaction size limit above the recombined completion, so WorkflowTaskCompletionPaginationIntegrationTest runs instead of always skipping.
jmaeagle99
force-pushed
the
fix-wft-pagination-retry-options
branch
from
October 30, 2026 22:11
e61119c to
edd94d4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
RpcRetryOptions.Builder(RpcRetryOptions)now copies the source options'doNotRetrylistinstead of reusing it.
history.enableWorkflowTaskCompletionPaginationand raises
system.transactionSizeLimitto 32 MiB.RpcRetryOptionsTest.aBuilderCopiedFromOptionsCanAddDoNotRetryItemsand aFixedCHANGELOG entry.
Why?
Workflow task completion pagination (#3051) is broken due to a bug in
RpcRetryOptionsbuilder. Pagination builds its retry options withRpcRetryOptions.newBuilder(builtOptions).addDoNotRetry(ABORTED, WorkflowTaskCompletionBufferLostFailure.class).RpcRetryOptionsstoresdoNotRetryas an unmodifiable list, and the copy builder reused that list, soaddDoNotRetryalways threwUnsupportedOperationException. It threw before the first page was sent. On a namespace with pagination enabled, every completion that needed pagination failed, and the workflow task timed out on every attempt.Any application calling
RpcRetryOptions.newBuilder(existing).addDoNotRetry(...)hit the same exception.CI never caught this because
WorkflowTaskCompletionPaginationIntegrationTestskips unless the namespace advertises the capability, and the server flag defaults tofalse. The dev-server flags make that test run. The larger transaction size limit is needed because the server stores the reassembled completion in a single write.Checklist
WorkflowTaskCompletionPaginationIntegrationTestpasses. With only theRpcRetryOptionschange reverted, it hangs until the test timeout and logsUnsupportedOperationExceptionfromaddDoNotRetry.GrpcMessageTooLargeTestand theio.temporal.payloadtests pass on the dev server with the new flags.RpcRetryOptionsTestandWorkflowWorkerTestpass.