Repository navigation
bench: String Encoding groups for string-bench rows - #152
Merged
Merged
Conversation
string-bench now writes into compression_times and compression_sizes, under the dataset `strings/<column>` with the encoder in dataset_variant. List those rows in their own "String Encoding" and "String Encoding Size" groups instead of mixing them into the compress-bench groups. - Compression group keys take an optional `suite: 'strings'`. The compress-bench group slugs stay byte-identical, so existing links and cache keys still resolve. - The string summaries compare each encoder with FSST at the newest string-bench commit, reusing the compression ranking code. The size card names its baseline instead of always saying Parquet. - The groups link to benchmarks/string-bench/README.md, and CONTRACT.md records the dataset prefix and the fsst baseline label. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01UeniBE69Jeaf1h8ZkLq7QB Signed-off-by: Joe Isaacs <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bench preview for |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vortex-data/vortex#11044 makes
string-benchwrite its Vortex file results intocompression_timesandcompression_sizes. Its rows use the datasetstrings/<column>, put the encoder (onpair-12,onpair-16,fsst) indataset_variant, and usevortex-file-compressedasformat. This PR lists those rows in their own String Encoding and String Encoding Size groups, so they don't mix into the compress-bench groups.No schema change or migration is needed. Either PR can merge first. If the monorepo PR lands first, its string charts appear inside the Compression groups until this deploys.
Changes
suite: 'strings'. The compress-bench group slugs stay byte-identical, so existing links and cache keys still resolve.strings/prefix. String chart names drop the prefix, e.g.fineweb/text/onpair-12. The new groups sort right after Compression Size.benchmarks/string-bench/README.mdand have hover descriptions.CONTRACT.mdrecords thestrings/prefix and thefsstbaseline label as part of the ingest contract.Checks
On the branch rebased onto
main, inbench/web:bun run biome ci bench,tsc --noEmitandnext buildall pass.vitest runagainst a local Postgres 16 (BENCH_TEST_DATABASE_URL): 60 files, 839 tests passed.New tests cover:
Generated by Claude Code