Repository navigation
Ingest string-bench results into the compression tables - #11044
Merged
Merged
Conversation
string-bench's Vortex file suite now writes v3 ingest records via a new --ingest-jsonl flag, and develop-bench ingests them into the existing compression_sizes and compression_times tables. Each (column, encoder) run emits one size row and encode (write) / decode (read) timing rows, with dataset `strings/<column>` and the encoder in dataset_variant so the rows never collide with compress-bench keys. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01UeniBE69Jeaf1h8ZkLq7QB Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
force-pushed
the
ji/upbeat-brown-y7naim
branch
from
October 30, 2026 15:30
b52d84f to
b0d522f
Compare
joseph-isaacs
marked this pull request as ready for review
October 30, 2026 15:30
robert3005
approved these changes
Oct 30, 2026
Merging this PR will improve performance by 10.38%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #10988, develop stores no String Encoding results, because string-bench emitted no ingest records. This PR lets string-bench write its Vortex file results into the existing
compression_sizesandcompression_timestables. It needs no new table or schema change.The website side is vortex-data/vortex.dev#152, which lists these rows in their own String Encoding and String Encoding Size groups. Either PR can merge first. If this one lands first, the string charts appear inside the Compression groups until the website deploys.
Changes
benchmarks/string-bench/src/serialized.rs: addsSerializedResult::v3_records(), built on the existingv3::compression_size_recordandv3::compression_time_recordhelpers. Each (column, encoder) run emits:compression_sizerecord: the Vortex file size, plus the column's canonical uncompressed sizecompression_timerecords:encodefor the file write anddecodefor the scan, each with its median and every runRecord keys. Every record uses:
strings/<column>onpair-12,onpair-16,fsst) asdataset_variantvortex-file-compressedThe prefix and the non-null variant keep these keys from colliding with compress-bench rows for the same columns (
l_comment, ClickBenchURL). The compress-bench summaries only use rows paired with Parquet, so string rows can't change them.benchmarks/string-bench/src/main.rs: adds an--ingest-jsonl <path>flag. Only the Vortex file suite is recorded; the codec suite is a local diagnostic that CI doesn't run.scripts/string-split.py: passes--ingest-jsonlfor each run and merges the outputs intoresults.ingest.jsonl..github/workflows/develop-bench.yml: setsv4_ingest: truefor string-bench and drops the comment saying its results aren't stored.PR runs need no further change.
pr-bench-runner.ymlalready fetches a develop baseline for string-bench fromresults.ingest.jsonl, so PR comments will compare against develop once develop has rows.I haven't compiled this or run clippy locally; CI will cover it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UeniBE69Jeaf1h8ZkLq7QB