Repository navigation
Stop writing benchmark results to S3 - #10988
Conversation
Merging this PR will improve performance by 10.24%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing |
|
The CodSpeed failure on Generated by Claude Code |
|
Generated by Claude Code |
Nothing reads `data.json.gz` or `commits.json` once PR comparisons read from the benchmarks database, and appending to the 353 MB `data.json.gz` was the slowest step of every develop benchmark job. Remove the S3 uploads, the `commit-metadata` job that only fed `commits.json` (`commit-metadata.yml` already records commits in Postgres), and `cat-s3.sh` and `commit-json.sh`. String Encoding has no database table yet, so develop no longer stores its results. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01UeniBBtX1DUban9Fda2Edh Signed-off-by: Joe Isaacs <[email protected]>
10c83ef to
3e8ffa7
Compare
Summary
After #10987, nothing reads
s3://vortex-ci-benchmark-results/data.json.gzorcommits.json. Appending to the 353 MBdata.json.gz(download, gunzip, append, gzip, upload, with ETag retries across parallel jobs) was the slowest step of every develop benchmark job. All results are already ingested into the benchmarks Postgres.