Skip to content

fix(deps): clear the CLI production audit with patched Zod - #91

Merged
purpshell merged 1 commit into
mainfrom
codex/cli-zod-audit-20261026
Oct 28, 2026
Merged

purpshell merged 1 commit into
mainfrom
codex/cli-zod-audit-20261026

Conversation

@purpshell

@purpshell purpshell commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Summary

npm run verify fails its production audit because the CLI directly pins Zod 4.2.0. Raise the dependency to ^4.6.6; the npm-generated lockfile resolves 4.6.7. This addresses GHSA-mrhx-c7xc-m3w5, whose patched floor is 4.6.6.

The change is two files, +6/-5. Only the root Zod requirement and its lock node change; all 282 other package nodes and the SDK pin 0.1.0-dev.20261004024706 remain unchanged. No audit suppression or application source changes.

This is independent maintenance for CLI main. It fixes the dependency failure exposed by CLI #79; #79 itself remains at 06a29d8 until this fix merges.

Impact

Impact table

Area Status and evidence
CLI validators and developer MCP Updated dependency. Compatibility checks cover every direct Zod consumer: MCP schemas, Flows/public-key registration, Functions, request logs, billing controls and Official API inputs.
Production dependency audit One high advisory before the update; zero production vulnerabilities afterward. The existing audit command is unchanged.
Feature/release integration Source fix only. A user or release owner must merge this PR, then main can be merged normally into #79. Its SDK350/package/installed-client acceptance hold remains.
Roadmap/session publication Coordinator-owned and not advanced here. Local partial visible-evidence checkpoint; no complete transcript or tracker synchronization claim.

No impact table

Area Reason and evidence
Customer API, schemas, scopes, SQL/RLS and server behavior No API repository or contract changes. Only CLI package metadata changes.
All six SDKs and SDK pin No SDK code or lock node changes; exact existing SDK version preserved. No registry package or accepted source claimed.
HyperMeow/Barback, runners/Bartender, Temporal, Signal and custody No native/runtime code, protocol, key, transport or placement changes.
Admin API, Admin Console and Admin MCP No staff capability, tool, gateway or state changes; no Admin MCP task invoked. The tested MCP is CLI developer stdio.
Console, Inspector, public/private Docs, Help Center and marketing No GUI, guide, version-example, changelog or availability copy changed. No public contract behavior intentionally changes.
Billing/PAYG, Usage, Analytics, consent, onboarding and Logs/audit No prices, meters, telemetry, server data, consent or authentication changes. Existing CLI validation/wire behavior is exercised by the compatibility checks.

Verification

Exact source c0b5c9524d9da19f0106b81f845f7b5124f629a9, tree cbacab918cfb63d3f96ea43dc3fad60603be82be, parent CLI main 58e91a18d1a4afc108eb3119db0830340bb2a926.

Installed Node24.15 and npm11.20, standard exclusive validation lease, private worktree/caches:

  • Red: production audit on the unchanged main lockfile reports one direct high Zod advisory, exit1.
  • npm-generated lockfile; fresh npm ci --ignore-scripts --no-audit --no-fund, followed by explicit build.
  • Build and complete CLI typecheck pass.
  • 79 compatibility tests in 11 focused files pass, serial worker.
  • Production audit reports zero vulnerabilities, exit0.
  • Formatting/whitespace and full dependency-graph preservation assertions pass.

The triggering Node22 job on #79 passed all 1,115 tests, formatting/lint/typecheck/build/pack, then failed only production audit. Hosted CI run 40292579866 passed on this exact commit, including the Node22 verification pipeline and release-evidence checks. Local checks used Node24. This is source/CI qualification, not registry, deployment or feature acceptance.

Session provenance and UI evidence

Sole ordinary Campaign owner thread 646a0c0a-e900-4d0f-9a25-0b8834d7d4e6, user-selected Codex gpt-6.1-sol/xhigh, no subagents or overlapping writer. Separate task worktree preserves #79 unchanged. Coordinator explicitly assigned this CLI fix separately from monorepo POL-34.

Local evidence: ~/.polymorfa-agent-work/cli-zod-audit-20261026/; committed sanitized checkpoint publication remains coordinator-owned. No screenshots apply: no GUI changes. Tests use existing synthetic/local fixtures; no real credentials/provider acceptance.

Rollout and rollback

A user or release owner must approve merging into CLI main; the coordinator's monorepo dev authority does not cover this merge. No main merge, registry publishing, tag or CI dispatch/rerun/cancel was performed. Existing nightly/stable acceptance and provenance requirements remain unchanged.

After this merges, normally merge CLI main into #79 without changing its SDK pin/filter gates; those wait for the accepted SDK350 package. If validation compatibility regresses, hold release and fix forward. Reverting to 4.2.0 would restore the known audit failure. No data migration or rollback is needed.

Final source-merge qualification — 28 October 2026

The current user directive authorizes Release to execute relevant source merges across the workstreams; package/registry and environment acceptance gates remain separate. Release independently verified the exact head, two-file patch, unchanged CLI main parent, successful hosted Node22 verification logs, and zero review threads/reviews.

The remaining RELEASING.md Actionlint requirement passed in the existing Docs owner's serialized validation claim: installed actionlint v1.7.12 (go1.25.12 darwin/arm64), explicit lint of both complete workflow files, exit0 with empty output. Their Git blobs are byte-identical at CLI main and this head: ci-hosted.yml d640123636864bd5107b7ad7ff5fea586664ab43; publish-dev.yml 993b2f319603b3ae3c2a1c74c10f83c18ce1df1e. Local execution is owner-reported; Release independently confirmed these source identities. Existing hosted production audit reports zero vulnerabilities; the dev-inclusive npm-ci advisory report is not represented as zero.

A normal exact-head source merge changes no SDK pin, publication workflow, protected release acceptance, tag or deployed availability. No publication dispatch, automated review request or CI rerun was made.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T08:30:56.491692Z c0b5c95 PR opened
🔒 Security Review ✅ Completed 2026-10-26T08:32:35.802688Z c0b5c95 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 151d0adf-7dc8-4bd1-968d-314b9e4bf549
Commits

Reviewing files that changed from the base of the PR and between 58e91a1 and c0b5c95.

Files ignored due to path filters: 1
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1
  • package.json

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Walkthrough

The zod dependency constraint in package.json changes from exact version 4.2.0 to compatible range ^4.6.6.

Changes: Zod dependency update

Layer / File(s) Summary
Update Zod version range
package.json
The declared zod version changes from exact version 4.2.0 to compatible range ^4.6.6.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

  • polymorfa/cli#90: Also updates the CLI root zod dependency from 4.2.0 to a patched 4.6.x version.
Merge Risk: Minimal · up to c0b5c

The dependency update is mergeable with no remaining review-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(deps): clear the CLI production audit with patched Zod" matches the main change. The PR raises the CLI's root Zod requirement from 4.2.0 to ^4.6.6 to clear a production audit advisory (…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(deps): clear the CLI production audit with patched Zod" matches the main change. The PR raises the CLI's root Zod requirement from 4.2.0 to ^4.6.6 to clear a production audit advisory (GHSA-mrhx-c7xc-m3w5). The title is specific, follows conventional commit style, and names the dependency and the reason for the change. It does not describe unrelated work.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant